Move pom operator into codemodder-java repo #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fully offline resolution * cleanup * [no ci] Autogenerated JaCoCo coverage badge --------- Co-authored-by: Jacoco Coverage Update Action <[email protected]>
…dder-java license
ryandens
force-pushed
the
ryandens/inline-pom-operator
branch
from
d6ba5e6
to
ddf1bd2
Compare
|
|
ryandens
commented
Aug 25, 2023
There was a problem hiding this comment.
@aldrinleal What does this test do that others don't? Why can't the contents of the java-sample test be inlined into this test suite?
There was a problem hiding this comment.
Its just to ensure it was able to be used from Java and consumed from a whole project without any Kotlin in a Vanilla JDK8 environment.
You can safely ignore that in your merging process (but perhaps wait bc I'd like to finish one more thing in the source pom-operator first)
|
Closing this PR until we're a bit closer to mergeable state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧